Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ugly output in short terminal windows #4

Closed
fkorotkov opened this issue Aug 24, 2020 · 2 comments · Fixed by #5
Closed

Ugly output in short terminal windows #4

fkorotkov opened this issue Aug 24, 2020 · 2 comments · Fixed by #5
Labels
bug Something isn't working

Comments

@fkorotkov
Copy link
Contributor

Seems there is an issue when terminal window doesn't have too many lines available. Reported from this Reddit comment:

Ah echelon tries to keep the job levels at the top of the currently-visible portion of the console, this is interesting. This only is an issue in case there are too many log lines. This makes the output very ugly though, apart from the last few lines. Just try the demo with passing false to all log.Finish calls.

Example for the issue:

🕒 Job 1 37s
🕒 Job 1 38s
   ❌ Job 4 8.0s
🕒 Job 1 39s
      Doing very important jobs! Completed 25/100...
🕒 Job 1 40s
🕒 Job 1 41s
🕒 Job 1 42s
🕒 Job 1 43s
      Doing very important jobs! Completed 87/100...
🕒 Job 1 44s
      
🕒 Job 1 45s
🕒 Job 1 46s
🕒 Job 1 47s
🕒 Job 1 48s
🕒 Job 1 49s
   ❌ Job 8 9.0s
@fkorotkov fkorotkov added the bug Something isn't working label Aug 24, 2020
fkorotkov added a commit that referenced this issue Aug 24, 2020
@fkorotkov
Respect terminal height
975cf72 
Fixes #4
@fkorotkov fkorotkov mentioned this issue Aug 24, 2020
Merged
@fabstu
Copy link

fabstu commented Aug 25, 2020

Looks nice! Now the out of scope timers and completion-icons (fail or succeed) won't be updated anymore (MacOS/ZFS). But it is definitely worse when the output gets mangled like before. Thank you 👍

@fkorotkov
Copy link
Contributor Author

Yeah, seems there is no way to edit outside of the terminal window. 😪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect terminal height cirruslabs/echelon
2 participants
@fkorotkov @fabstu