Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User controlled wallet SDK needs update #13

Open
eltontay opened this issue Oct 7, 2024 · 0 comments
Open

User controlled wallet SDK needs update #13

eltontay opened this issue Oct 7, 2024 · 0 comments
Labels
bug Something isn't working dependencies Pull requests that update a dependency file

Comments

@eltontay
Copy link

eltontay commented Oct 7, 2024

Title: User Controlled Wallet SDK Needs Update

Issue Description:
The User Controlled Wallet SDK version 4.0.0 does not support certain chains. However, version 4.5.0 includes support for these chains.

This update causes a break in the following line:

import { CreateUserWithPinChallenge200Response } from '@circle-fin/user-controlled-wallets/dist/types/clients/user-controlled-wallets';

Steps to Reproduce:

Attempt to use SDK version 4.0.0 with specific chains.
Observe the import statement in onboarding.ts (line 22) causes issues.
Expected Behavior: The SDK should support the specified chains without causing compilation or runtime errors.

Actual Behavior: Attempting to import CreateUserWithPinChallenge200Response from the SDK leads to an error.

Additional Context: Please consider updating the documentation and the SDK to ensure seamless usage with the specific chains in question, as this was a known issue in version 4.0.0 and may affect other users.

Suggested Fix: Review the changes made in version 4.5.0 to ensure compatibility with existing functionality and chains supported.

@eltontay eltontay added bug Something isn't working dependencies Pull requests that update a dependency file labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

1 participant