Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc example doesn't seem to work #1

Open
zbjornson opened this issue Aug 14, 2018 · 1 comment
Open

Doc example doesn't seem to work #1

zbjornson opened this issue Aug 14, 2018 · 1 comment

Comments

@zbjornson
Copy link

It looks like the readme examples are out of date.

In the Base Server example, dns.Server is undefined (it's not exported from require("bns")).

If I change it to bns.DNSServer, server.on("query") is never invoked and an assertion error is emitted from server.on("error").

If I change it to bns.AuthServer, server.on("query") is invoked, but it looks like you shouldn't call res.send() ("res.send is not a function" is emitted). An assertion error happens in this case also.

If I change it to bns.StubServer, ditto, except Error: No servers available is emitted instead of the assertion failure.

Since you're apparently not supposed to call res.send(), does that mean it's not possible to have an async response?

([email protected])

@jafri
Copy link

jafri commented Apr 16, 2019

@chjj same issue here, bns.Server should be bns.DNSServer in docs and server.on("query") is never invoked following the example code...cannot get this library working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants