Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in metric calculation #173

Open
yifangyin opened this issue Nov 15, 2024 · 0 comments
Open

Bug in metric calculation #173

yifangyin opened this issue Nov 15, 2024 · 0 comments

Comments

@yifangyin
Copy link

In OpenSTL/openstl/core/metrics.py, 't' in the input represents the threshold, but this 't' got overwritten by the first line 't = np.greater_equal(x, t).astype(np.float32)' where 't' refers to 'true' in the output. The input 't' should be renamed.

Also in line 138: t, p = _threshold(pred[i], true[i], threshold) the order of inputs is wrong. It should be t, p = _threshold(true[i], pred[i], threshold).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant