-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong rendering assumption when using @
in markdown files
#228
Comments
@marcelarie Good catch! Thank you for reporting this. I'm going to move this over to Glamour, the markdown rendering library that handles the markdown rendering under the hood in Glow. I'll be sure to bring it to the attention of the team. |
Cool, thanks! |
FWIW: one workaround (for now) would be to put it inside a codeblock |
I looked into this; it seems to be consistent with other markdown renderers. It's our upstream dependency goldmark that's autolinking email addresses if it matches the HTML5 regex in the CommonMark Spec. I wrote some tests to reproduce the behaviour you're experiencing in Goldmark. Based on their note in their issue template, I don't think they're going to change how they're handling emails. We might consider how we want to handle the type we get back from the autolinking... I'll discuss with the team to see what they think :) |
glow version 1.5.0
I found a difference between
bat
andglow
, and I think thatbat
has the correct output on this one. Seems thatglow
assumes that any two strings separated by a@
are a mail address.Here is an example of the
bat
output:Here is an example of the
glow
output:You can see how the
mailto:
link is generated.This is the content of the file:
The text was updated successfully, but these errors were encountered: