Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set duck volume to 0 on iOS #86

Open
samuelbeard opened this issue Nov 12, 2024 · 1 comment
Open

Set duck volume to 0 on iOS #86

samuelbeard opened this issue Nov 12, 2024 · 1 comment

Comments

@samuelbeard
Copy link
Collaborator

samuelbeard commented Nov 12, 2024 •
edited
Loading

iOS doesn't allow partial volume increments. On the charisma-web, we have overridden this to duck to 0 if the device is iOS. We should move that code to the SDK itself.
WebComicMicrophoneButton.tsx:

if (isIOS()) {
  setMediaVolume(0);
}
@samuelbeard
Copy link
Collaborator Author

Annette tested this on iPhone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samuelbeard