-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
agenda does't work if I use Arabic Language #2823
Comments
Hi @Haboubi92 |
thank you so much for your reply ♥ |
OK, so the first issue here (not the only one apparently) is that we are missing the translations for the calendar UI, which is a bit tricky because we depend on a plugin of jquery-ui-calendar for that. The best way to deal with this would be for you to translate the corresponding file here: https://github.com/trentrichardson/jQuery-Timepicker-Addon/tree/master/dist/i18n Apparently someone already did that here: trentrichardson/jQuery-Timepicker-Addon#956 but the author of the library did not accept it yet (since September). I'm adding a comment there to ask him to do so. I suggest you also do it, so it is included. This is not all though, there seems to be another issue. |
I've sent the previous change to Chamilo to prevent the page from failing on the missing .ar.js file. I'm having another issue now but I'm not entirely sure this is not some caching side-effect (of attempting to just create the .ar.js file, which didn't work as is). |
OK, so the remaining issue with adding an event is that the ajax is called with arabic characters for the dates: /main/inc/ajax/agenda.ajax.php?type=personal&a=get_events&start=٢٠١٩-٠١-٢٨&end=٢٠١٩-٠٣-١١&_=1551747984935 |
@jmontoyaa it looks like we are doing one convertion to Arabic in the start and end variables that we shouldn't do (or if we do, we should also convert it back to English universal dates in order to store them in the database). |
@Haboubi92 not sure that is you, but if it is: thank you for updating the translation to Arabic from https://translate.chamilo.org/ ! Much appreciated. |
@ywarnier |
@AngelFQC |
Because of the issue, some incorrect events might have created in the database, which might block the use of the calendar anyway. To fix those, you can run (safely) the 2 following queries in your database:
|
I have updated https://11.chamilo.org and https://campus.chamilo.org with the fix, so @Haboubi92 you should be able to test it on any of those 2 portals and confirm it is working. |
@Haboubi92 a quick question: are calendars normally also presented this way (from right to left) in arabic? We're not sure it should be like that... |
@ywarnier |
Excellent news! |
Describe
I can't add or view events when I use Arabic Language
To Reproduce
or clicking on agenda icon from any course, or clicking on global agenda from administration tab.
Expected behavior
you'll see "loading" as shown in screenshot and you won't be able to add or view any events.
Screenshots
Desktop (please complete the following information):
I also tried it on chrome mobile application running on android 7
**Server
I have this error in ♥ Chamilo ♥ version 1.11.4 on php 7
also I had the same error in ♥ Chamilo ♥ version 1.11.8 on php 7.2
OS (linux)
Additional context
I experience this error only when language is set on Arabic, but there is no problem when I change the language back to English.
The text was updated successfully, but these errors were encountered: