Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move business logic out of gRPC handler module #469

Open
ekrembal opened this issue Jan 24, 2025 · 0 comments
Open

Move business logic out of gRPC handler module #469

ekrembal opened this issue Jan 24, 2025 · 0 comments
Labels
code quality Improves code quality while not affecting any other enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@ekrembal
Copy link
Member

ekrembal commented Jan 24, 2025 •
edited by ceyhunsen
Loading

Right now, we need to do create_actors! then call aggregator.setup before doing any tests. This slows down our testing. Instead, every test should be able to spawn an entity to do it's job without creating a gRPC server.
@ekrembal ekrembal mentioned this issue Jan 24, 2025
Merged
@ceyhunsen ceyhunsen changed the title Research testing without gRPC Move out business logic outside of RPC crate Jan 27, 2025
@ceyhunsen ceyhunsen added enhancement New feature or request help wanted Extra attention is needed question Further information is requested code quality Improves code quality while not affecting any other labels Jan 27, 2025
@mmtftr mmtftr changed the title Move out business logic outside of RPC crate Move out business logic out of RPC crate Jan 28, 2025
@mmtftr mmtftr changed the title Move out business logic out of RPC crate Mov business logic out of RPC crate Jan 28, 2025
@mmtftr mmtftr changed the title Mov business logic out of RPC crate Move business logic out of RPC crate Jan 28, 2025
@mmtftr mmtftr changed the title Move business logic out of RPC crate Move business logic out of gRPC handler module Jan 28, 2025
@mmtftr mmtftr mentioned this issue Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Improves code quality while not affecting any other enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ekrembal @ceyhunsen