Failed test due to DatabaseError (rpc::aggregator::tests::aggregator_setup_and_deposit)

[mmtftr]

Proposal Description

Description

• Fails rpc::aggregator::tests::aggregator_setup_and_deposit

We have a failed test due to a database error happening inside of the create_nofn_sighash_stream's stream. @ozankaymak advised that we should be revising the database code before we attempt to resolve the issue.

First encountered in #423

[ceyhunsen]

What is the error exactly? And can you give a link to CI/CD example of the error, if present?

[mmtftr]

This is the CI run but the logs are way too long (~60MB) to reasonably debug. I hopped into a debugger to find out it was a DatabaseError.

I think we have a lot of work to do in terms of tracing, standardized error types, and error propagation. Some priority items:

• standardize a way to filter logs from our modules for a better debugging experience. tracing supports many filters that'd allow us to do so, but we need to look into it. Currently, the log filter is just set to level VERBOSE and outputs absolutely everything.
• standardize error propagation across the stack: BridgeError and Status are used in different places, we should stick to one (likely BridgeError over Status) and stick to it.
• include source in BridgeErrors (a super nice to have for debugging // better backtraces)
• ...possibly more (I think looking into the rust error handling ecosystem might be a good time investment

[mmtftr]

// docker logs ...
2025-01-20T13:29:46.2692965Z  2025-01-20 13:25:43.807 UTC [366] ERROR:  duplicate key value violates unique constraint "header_chain_proofs_pkey"
// our app logs ...
2025-01-20T13:29:45.7784468Z �[2m2025-01-20T13:28:50.557248Z�[0m �[31mERROR�[0m �[2mclementine_core::rpc::aggregator�[0m�[2m:�[0m Error when reading from sighash stream: DatabaseError: pool timed out while waiting for an open connection

@ceyhunsen I believe it's one of these