New: logger added, console logs replaced, additional logs added (fixes #15) #16
+187
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverfoster
requested changes
May 17, 2024
| const m = d.getMonth() + 1 | ||
| const date = `${d.getDate()}/${m < 10 ? `0${m}` : m}/${d.getFullYear().toString().slice(2)}` | ||
| const time = `${d.getHours()}:${d.getMinutes()}:${d.getSeconds()}:${d.getMilliseconds()}` | ||
| const str = `${date} - ${time}` |
There was a problem hiding this comment.
Use YYMMDD order instead of DDMMYY as American MMDDYY vs European date format.
|
|
||
| //Colour level for easy read, store log in this.logArr as string | ||
| log(level, args) { | ||
| const colour = this?.config?.levels[level]?.colour || 'grey' |
There was a problem hiding this comment.
Probably need a way of doing --verbose like flag which outputs debug level logs.
|
|
||
| const outputName = `${type}_log` | ||
| const outputFile = path.join(logPath, `${outputName}.json`) | ||
| fs.writeJSONSync(outputFile, this.logArr, { replacer: null, spaces: 2 }); |
There was a problem hiding this comment.
The logger should probably not write to disk as this might only be applicable for hand built courses. In the AAT you may find you want the result of this as an variable value only?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15
New: logger added, console logs replaced, additional logs added (fixes #15)