Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default for _imageAlignment for popup images #149

Closed
swashbuck opened this issue Mar 26, 2024 · 0 comments · Fixed by #150
Closed

Set default for _imageAlignment for popup images #149

swashbuck opened this issue Mar 26, 2024 · 0 comments · Fixed by #150
Assignees
@kirsty-hames
Labels
bug

Comments

@swashbuck
Copy link
Contributor

Subject of the issue

Currently, the _imageAlignment property is required to be set in order for a popup image to appear. Can we default to _imageAlignment: "left" or something so that this doesn't break popup images?

https://github.com/cgkineo/adapt-hotgrid/blob/master/templates/hotgridPopup.jsx

Relates to similar issue with Hot Graphic:
adaptlearning/adapt-contrib-hotgraphic#301
@kirsty-hames kirsty-hames self-assigned this Apr 24, 2024
@kirsty-hames kirsty-hames mentioned this issue Apr 24, 2024
Merged
kirsty-hames added a commit that referenced this issue Apr 29, 2024
@kirsty-hames
Fix: Set default for _imageAlignment for popup images (fixes #149) (#150
ccaee3f 
)

* provide a default display of _imageAlignment: "right" in the instance _imageAlignment isn't set

* only apply _imageAlignment class if item has image
github-actions bot pushed a commit that referenced this issue Apr 29, 2024
@semantic-release-bot
Chore(release): 4.5.3 [skip ci]
8a75a5b 
## [4.5.3](v4.5.2...v4.5.3) (2024-04-29)

### Fix

* Set default for _imageAlignment for popup images (fixes #149) (#150) ([ccaee3f](ccaee3f)), closes [#149](#149) [#150](#150)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirsty-hames kirsty-hames

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Set default for _imageAlignment for popup images (fixes #149) cgkineo/adapt-hotgrid
2 participants
@swashbuck @kirsty-hames