Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e] Failing tests #987

Closed
5 tasks done
Tracked by #283
meissadia opened this issue Oct 4, 2024 · 1 comment · Fixed by #1004 or #1036
Closed
5 tasks done
Tracked by #283

[e2e] Failing tests #987

meissadia opened this issue Oct 4, 2024 · 1 comment · Fixed by #1004 or #1036
Assignees
@meissadia

Comments

@meissadia
Copy link
Collaborator

meissadia commented Oct 4, 2024 •
edited
Loading

Overview

What I see running Playwright with 1 worker, after starting clean

playwright-1-worker-mdia

Attempted fixes

  • Re-install Chromium

Screenshots
@meissadia meissadia self-assigned this Oct 16, 2024
@meissadia meissadia mentioned this issue Oct 16, 2024
Merged
@meissadia meissadia linked a pull request Oct 16, 2024 that will close this issue
[e2e] unavailableApis.spec - Refactor + add extended timeouts #1004
Merged
@billhimmelsbach
Copy link
Contributor

Related to: cfpb/sbl-project#283

@billhimmelsbach billhimmelsbach mentioned this issue Oct 17, 2024
Open
9 tasks
tanner-ricks added a commit that referenced this issue Oct 17, 2024
@meissadia @tanner-ricks
[e2e] unavailableApis.spec - Refactor + add extended timeouts (#1004)
4a12d6c 
Part of #987 

## Changes

- [e2e] Unavailable APIs
- Refactored to make the tests easier to read and reduce code
duplication (`verifyApiBlockThenUnblock()`)
  - Added timeouts to enable test to consistently pass

## How to test this PR

1. Start `sbl-frontend`: `yarn start`
2. Open Playwright: `yarn playwright test --ui --workers 1`
3. Run test `filing-app` -> `unavailableApis.spec.ts` twice
4. Confirm it passes consistently

## Screenshots

<img width="371" alt="Screenshot 2024-10-16 at 3 19 23 PM"
src="https://github.com/user-attachments/assets/844013ed-8bd2-43e4-bbc4-5e65e8e23127">

<img width="835" alt="Screenshot 2024-10-16 at 3 22 14 PM"
src="https://github.com/user-attachments/assets/56e9f645-feb1-478c-8601-9a83f7ad533c">

## Notes
- TODO (Future PR): Utilize `e2e/utils/timeoutConstants.ts` in more
tests to reduce one-off timeout values

---------

Co-authored-by: Tanner Ricks <[email protected]>
@meissadia meissadia reopened this Oct 17, 2024
@meissadia meissadia mentioned this issue Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meissadia meissadia

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@meissadia @billhimmelsbach