-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mechanism to keep contributors list up to date #230
Comments
Thanks for merging the update and for opening this issue, Daniel @erget. In order to make it a bit easier for moderators, perhaps we could ask them in Happy Friday Jonathan |
Hi @JonathanGregory , I'm not opposed to the approach in general, but would prefer to keep the communications on GitHub rather than via email to the 2 officers. What do you think of asking the moderator to tag them when a discussion concludes? In that case both would get an email (unless they've turned off those types of notifications) and the discussion would all take place on the same platform. |
Perhaps even simpler than that would be for the moderator to mention significant contributors to the successful conclusion of the discussion when they wind up the issue. |
True... Under the assumption that that gets caught by another process that sweeps up the concluded issues. Could be a period review of all the closed issues, for example, but something would need to happen to pick up the mentions. |
Yes, that's right, but I think we have to sweep the issues anyway in order to catch the ones which were closed inconclusively. |
Ok. So that means we'd need 2 updates, both in the Conventions repo:
Correct? |
Yes, that looks right to me. I think it would work. Thanks. |
Please check the PR associated with this issue - I think that solves it, but needs to be merged along with the procedural update referenced in the commit. |
Just to register my support for the proposed approach negotiated between @erget and @JonathanGregory . |
Thanks @taylor13 @JonathanGregory . Slight correction: I've moved all changes onto the original PR that spawned this discussion: cf-convention/cf-conventions#372 (on release procedure). That has changes both to RELEASE.md and CONTRIBUTING.md. |
That looks fine. Thanks very much, @erget. J |
I'm also happy with the solution on the table - thanks, all. |
Ok, I'm closing this issue then because the changes are all in cf-convention/cf-conventions#372; I'll note they've been agreed in that discussion. |
Sorry I missed this discussion. I was out for a long weekend. I still prefer the option of having moderators create a PR to capture the additions to the contributor list. It seems less prone to error or missing an addition altogether. And, while an additional step, it is a pretty straight forward step that can easily be done through the GitHub web interface, through the edit page for the contributor list file. On the other hand, I'm don't feel that strongly about it. So, I'm good with the above agreed plan. |
Sad to say, I have not yet learned how to create a PR. There might be other fuddy duddy potential moderators in the same boat, who might decline to moderate a discussion to avoid having to learn how to create a PR. So thanks for not feeling "strongly about it". |
We need to keep the contributors list up to date. Some ideas floating around have been
CONTRIBUTING.md
to have authors or moderators open a new PR for the website when closing a discussionMight be a better way to do this that's not encompassed in what's above.
People who've already expressed interest: @JonathanGregory @davidhassell @ethanrd @taylor13
Originally posted by @erget in #227 (comment)
The text was updated successfully, but these errors were encountered: