Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run spell checker in a pre-commit hook #1054

Open
irbekrm opened this issue Aug 9, 2022 · 0 comments
Open

Run spell checker in a pre-commit hook #1054

irbekrm opened this issue Aug 9, 2022 · 0 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@irbekrm
Copy link
Contributor

irbekrm commented Aug 9, 2022 •
edited
Loading

We often find spelling errors only after having made a PR and have to go back and fix them.

It is possible to run ./scripts/_verify locally before creating the PR, but this seems to be easier forget than i.e running the tests before a code PR as it does not fit into the workflow so well.

As @hawksight suggested we could run the verify script in an optional pre-commit hook #1049 (comment)
@irbekrm irbekrm added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@irbekrm