Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ResourceIdentity <=> to take resource_klass into account when sorting. #1429

Open
3 of 7 tasks
lgebhardt opened this issue Jan 13, 2024 · 0 comments
Open
3 of 7 tasks
Assignees

Comments

@lgebhardt
Copy link
Member

lgebhardt commented Jan 13, 2024

This issue is a (choose one):

  • Problem/bug report.
  • Feature request.
  • Request for support. Note: Please try to avoid submitting issues for support requests. Use Gitter instead.

Checklist before submitting:

  • I've searched for an existing issue.
  • I've asked my question on Gitter and have not received a satisfactory answer.
  • I've included a complete bug report template. This step helps us and allows us to see the bug without trying to reproduce the problem from your description. It helps you because you will frequently detect if it's a problem specific to your project.
  • The feature I'm asking for is compliant with the JSON:API spec.

Description

I propose we compare the resource_klass.name first and then the ids. This would result in grouping of identities by type before ids. Since any sorting of these does not affect compliance with the spec I consider this a minor issue for polymorphic arrays of related identities.

@lgebhardt lgebhardt self-assigned this Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant