Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug report templates #1383

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bug report templates #1383

wants to merge 1 commit into from

Conversation

codeguru42
Copy link

@codeguru42 codeguru42 commented Feb 11, 2022 •
edited
Loading

https://github.com/jruby/activerecord-jdbc-adapter no longer has a rails-5 branch

Closes #1382.

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

@codeguru42
Copy link
Author

@lgebhardt @dgeb Does this appear to be sufficient to fix the bug report template? Any suggestions of anything else to look at to change?

bf4
bf4 reviewed Jan 17, 2024
View reviewed changes
lib/bug_report_templates/rails_5_latest.rb
@@ -13,7 +13,6 @@

gem 'activerecord-jdbcsqlite3-adapter',
git: 'https://github.com/jruby/activerecord-jdbc-adapter',
branch: 'rails-5',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think per https://github.com/jruby/activerecord-jdbc-adapter the correct approach would be branch 50-stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bf4 bf4 bf4 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug report template is broken
3 participants
@codeguru42 @bf4 @layne-vyne