Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ruby 3.1 and Rails 7.0 #1378

Open
3 of 7 tasks
petergoldstein opened this issue Feb 2, 2022 · 16 comments
Open
3 of 7 tasks

Add support for Ruby 3.1 and Rails 7.0 #1378

petergoldstein opened this issue Feb 2, 2022 · 16 comments

Comments

@petergoldstein
Copy link
Contributor

This issue is a (choose one):

  • Problem/bug report.
  • Feature request.
  • Request for support. Note: Please try to avoid submitting issues for support requests. Use Gitter instead.

Checklist before submitting:

  • I've searched for an existing issue.
  • I've asked my question on Gitter and have not received a satisfactory answer.
  • I've included a complete bug report template. This step helps us and allows us to see the bug without trying to reproduce the problem from your description. It helps you because you will frequently detect if it's a problem specific to your project.
  • The feature I'm asking for is compliant with the JSON:API spec.

Description

Features:

jsonapi-resources should support Ruby 3.1 and Rails 7.0, as these are now the most recently released versions of Ruby and Rails respectively. To ensure that these versions are supported, they need to be included in the CI matrix.

@connorgurney
Copy link

Is this still underway, @petergoldstein? We're looking to use the gem @breakthroughparty but are obviously eager to make sure it's going to work. Thanks. 🧡

@petergoldstein
Copy link
Contributor Author

@connordoner I submitted this PR - #1379 - to resolve this issue a while back.

@connorgurney
Copy link

Thanks, @petergoldstein — I missed that! Appreciate the response. 👍🏻

@benlieb
Copy link

benlieb commented Dec 28, 2022

So is Rails 7 supported?

@connorgurney
Copy link

So is Rails 7 supported?

I don’t think so, @benlieb — the PR remains open.

@petergoldstein
Copy link
Contributor Author

For whatever it's worth, I updated the PR with Ruby 3.2 and the latest Rails patch versions. I also pinged @lgebhardt and @dgeb . The former has no visible commits in some time, so I pinged @dgeb as another owner of the cerebris organization.

@connorgurney
Copy link

Would either of you be interested if I were to fork the repo and merge the PR? I recognise it’s not an ideal long-term solution but it’ll avoid this blocking other work.

@petergoldstein
Copy link
Contributor Author

@connordoner I'm not using this gem at this point - I'm just keeping my earlier PR up to date at this point.

I think the question is whether or not this gem is still maintained and, if so, who is the maintainer. I don't see any maintainer activity since March, when the release-0-10 branch was updated. Ideally you'd get the maintainer to merge key PRs and put out an update. But if that's not going to happen, forking is the next best option.

@connorgurney
Copy link

Is there any intention to maintain this package your end please, @dgeb @HeatherGebhardt @lgebhardt? If not, we’ll fork it, but I’d rather give you the chance first.

@rubylevelup
Copy link

@connordoner will you fork this repo?

@benlieb
Copy link

benlieb commented Feb 1, 2023

Just use Graphiti

@connorgurney
Copy link

@connordoner will you fork this repo?

Sure thing - see connordoner/jsonapi-resources.

@connorgurney
Copy link

Do either of you have any continuing interest in this issue, @petergoldstein and @rubylevelup? If not, I'll delete the fork, as I haven't used this gem recently.

@rubylevelup
Copy link

@connordoner thanks for letting me know. have not used the fork. you can delete it.

@petergoldstein
Copy link
Contributor Author

@connordoner Same for me. Feel free to delete if you'd like.

@connorgurney
Copy link

Thanks, both! It's a shame that this appears unmaintained now, but so be it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants