-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Ruby 3.1 and Rails 7.0 #1378
Comments
Is this still underway, @petergoldstein? We're looking to use the gem @breakthroughparty but are obviously eager to make sure it's going to work. Thanks. 🧡 |
@connordoner I submitted this PR - #1379 - to resolve this issue a while back. |
Thanks, @petergoldstein — I missed that! Appreciate the response. 👍🏻 |
So is Rails 7 supported? |
I don’t think so, @benlieb — the PR remains open. |
For whatever it's worth, I updated the PR with Ruby 3.2 and the latest Rails patch versions. I also pinged @lgebhardt and @dgeb . The former has no visible commits in some time, so I pinged @dgeb as another owner of the cerebris organization. |
Would either of you be interested if I were to fork the repo and merge the PR? I recognise it’s not an ideal long-term solution but it’ll avoid this blocking other work. |
@connordoner I'm not using this gem at this point - I'm just keeping my earlier PR up to date at this point. I think the question is whether or not this gem is still maintained and, if so, who is the maintainer. I don't see any maintainer activity since March, when the |
Is there any intention to maintain this package your end please, @dgeb @HeatherGebhardt @lgebhardt? If not, we’ll fork it, but I’d rather give you the chance first. |
@connordoner will you fork this repo? |
Just use Graphiti |
Sure thing - see connordoner/jsonapi-resources. |
Do either of you have any continuing interest in this issue, @petergoldstein and @rubylevelup? If not, I'll delete the fork, as I haven't used this gem recently. |
@connordoner thanks for letting me know. have not used the fork. you can delete it. |
@connordoner Same for me. Feel free to delete if you'd like. |
Thanks, both! It's a shame that this appears unmaintained now, but so be it. |
This issue is a (choose one):
Checklist before submitting:
Description
Features:
jsonapi-resources should support Ruby 3.1 and Rails 7.0, as these are now the most recently released versions of Ruby and Rails respectively. To ensure that these versions are supported, they need to be included in the CI matrix.
The text was updated successfully, but these errors were encountered: