Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

currentRootSpan != root on notifyStart #534

Closed
jinmel opened this issue May 17, 2019 · 2 comments
Closed

currentRootSpan != root on notifyStart #534

jinmel opened this issue May 17, 2019 · 2 comments
Labels

Comments

@jinmel
Copy link
Contributor

jinmel commented May 17, 2019

Please answer these questions before submitting a bug report.

What version of OpenCensus are you using?

0.0.12

What version of Node are you using?

10

What did you do?

If possible, provide a recipe for reproducing the error.

just run examples/grpc server and client with logLevel: 'debug' on tracer

What did you expect to see?

What did you see instead?

[debug] "2019-05-17T09:51:38.568Z" 'currentRootSpan != root on notifyStart. Need more investigation.'
[debug] "2019-05-17T09:51:38.568Z" 'starting to notify listeners the start of spans'
[debug] "2019-05-17T09:51:38.652Z" 'currentRootSpan != root on notifyEnd. Need more investigation.'
[debug] "2019-05-17T09:51:38.652Z" 'starting to notify listeners the end of spans'

Additional context

tracer.startRootSpan calls base_tracer.startRootSpan which then calls rootspan.start().

rootspan.start() calls tracer.onStartSpan() and there it checks whether currentRootSpan is equal to root span that is requested to be started.

Is this correct for any reason? if a new root span is created, it SHOULD be different from currentRootSpan.

This symptom happens for all instrumentation, http, grpc, mongodb and so on.

@jinmel jinmel added the bug label May 17, 2019
@mayurkale22 mayurkale22 added the P0 label May 17, 2019
@mayurkale22
Copy link
Member

Thanks for filling the issue. This issue has been addressed in #532, PTAL.

@jinmel
Copy link
Contributor Author

jinmel commented May 18, 2019

Wow that was fast. I was going to fix it myself during weekends but thanks anyway :)

@jinmel jinmel closed this as completed May 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants