Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple update to add more context to content #57

Open
1 task
idiom-bytes opened this issue Nov 28, 2022 · 0 comments
Open
1 task

Simple update to add more context to content #57

idiom-bytes opened this issue Nov 28, 2022 · 0 comments

Comments

@idiom-bytes
Copy link

Problem

Many .json files determine whether something is a download or not, however the FE doesn't reflect this. For a simple implementation use the inline conditional text, to label the Button as "Download" or "View"

Example: assets/index.tsx

<Button
  text={asset.download ? "Download" : "View"}
  link={asset.download ? `/assets/${asset.file}` : asset.file}
  self={asset.download}
/>

DoD:

  • All button text is wrapped in conditional clause to better communicate "Download" vs. "View"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant