Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need the correct compliance and non-compliance test cases for the typescript-cdk rules #1574

Open
csubhras opened this issue Jan 23, 2024 · 1 comment
Labels
guidance Question that needs advice or information. response-requested waiting on additional information or feedback

Comments

@csubhras
Copy link

csubhras commented Jan 23, 2024

General Issue

https://github.com/cdklabs/cdk-nag/blob/main/RULES.md#errors

The Question

We need correct compliance and non-compliance test cases for the below rules, found that both compliance and non-compliance test cases having similar code snippets on below rules.

cdk-nag version

CDK V2

Language

Typescript

Other information

No response

@csubhras csubhras added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Jan 23, 2024
@csubhras csubhras changed the title Need the correct compliance and non-compliance test cases for the rules Need the correct compliance and non-compliance test cases for the typescript-cdk rules Jan 23, 2024
@dontirun
Copy link
Collaborator

Are you asking what actual rule file the AwsSolutions NagPack uses? If so you can can see the mappings here. For example

this.applyRule({
ruleSuffixOverride: 'ECS7',
info: 'One or more containers in the ECS Task Definition do not have container logging enabled.',
explanation:
"Container logging allows operators to view and aggregate the logs from the container. Containers should use the 'awslogs' driver at a minimum.",
level: NagMessageLevel.ERROR,
rule: ECSTaskDefinitionContainerLogging,
node: node,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guidance Question that needs advice or information. response-requested waiting on additional information or feedback
Projects
None yet
Development

No branches or pull requests

2 participants