Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Table Support in GraphWidgetType #550

Open
Laxenade opened this issue Jul 23, 2024 · 3 comments
Open

Data Table Support in GraphWidgetType #550

Laxenade opened this issue Jul 23, 2024 · 3 comments
Labels
feature-request New feature

Comments

@Laxenade
Copy link
Contributor

Feature scope

Custom

Describe your suggested feature

It looks like the data table type is missing from GraphWidgetType. I'm not sure if the data table is a recent widget that CW added or if there hasn't been a use case for it.

export enum GraphWidgetType {
BAR = "Bar",
LINE = "Line",
PIE = "Pie",
SINGLE_VALUE = "SingleValue",
STACKED_AREA = "StackedArea",
}

It doesn't seem to be too hard to add. I can probably do a PR. I just wanted to confirm the scope first.

@Laxenade Laxenade added the feature-request New feature label Jul 23, 2024
@Laxenade
Copy link
Contributor Author

TableWidget was added in cdk-lib 5 months ago, so it's relatively recent.

aws/aws-cdk@4599aa3

@echeung-amzn
Copy link
Member

Looks like we'd need to bump to minimum [email protected] to get TableWidget, but we're currently at min 2.112.0. Bumping that would be a breaking change/major version bump, or temporarily maintaining a copy of it.

I'm not particularly a fan of either right now unless we wanted to bring in other new features from newer aws-cdk-lib versions too. Any thoughts from your end?

@Laxenade
Copy link
Contributor Author

That's fair. I don't have a strong need for it; I was just playing around with different widgets.

@echeung-amzn echeung-amzn added the needs-newer-aws-cdk-lib Requires bumping up our peer dependency. label Aug 23, 2024
@echeung-amzn echeung-amzn removed the needs-newer-aws-cdk-lib Requires bumping up our peer dependency. label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature
Projects
None yet
Development

No branches or pull requests

2 participants