Ancillary and garbage support #635
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onstants and .garbage entries in .real file
…uts to inputs via output_permutation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
=======================================
+ Coverage 87.0% 87.1% +0.1%
=======================================
Files 125 125
Lines 13781 14100 +319
Branches 2164 2214 +50
=======================================
+ Hits 11996 12294 +298
- Misses 1785 1806 +21
|
… removed from output permutation if output is marked as garbage
…ior to push of new changes
burgholzer
added
enhancement
|
Please make sure to add appropriate tests covering your changes and to resolve all clang-tidy warnings. You can see the clang-tidy warnings in the "Files Changed" tab here on GitHub or here: https://github.com/cda-tum/mqt-core/actions/runs/9686994807?pr=635#summary-26730667014 Tests should probably go into their own new file here: https://github.com/cda-tum/mqt-core/tree/main/test/unittests similar to https://github.com/cda-tum/mqt-core/blob/main/test/unittests/test_qasm3_parser.cpp |
…SWAP. Small changes due to clang-tidy checks.
…e entries. Added validation that no IO with ident equal to any variable ident is defined and no duplicate variable ident is defined.
…stringified gates created in test
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…t or must be marked as garbage.
…lso be reused for processing of gate list lines
…le idents instead of numeric qubit values (the latter are used in the corresponding functionality of the qasm_parser)
… line vector during processing of gate list entries
…h possible header component. Added check that no duplicate header components were defined.
…acters for in header as well as gate definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for ancillary as well as garbage definitions to the
.realfile parser. Additionally, the default 1-1output_permutationis update if matching entries in the.inputdefinitions exist for any.outputdefinition (see mqt-core documentation)Fixes #88
Checklist: