Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard-coding of BCH polynomial #1

Open
cburkert opened this issue Jul 19, 2018 · 3 comments
Open

Remove hard-coding of BCH polynomial #1

cburkert opened this issue Jul 19, 2018 · 3 comments

Comments

@cburkert
Copy link
Owner

The hard-coded polynomial was taken from bchlib's example. This limits the supported range of fuzziness thresholds and should rather be chosen dynamically based on the FCS parameters.

@cburkert
Copy link
Owner Author

Polynomial is made user-definable in 1621ea6

@Asrar-b
Copy link

Asrar-b commented Apr 23, 2020

Hi,
is this argument mean n in BCH(n,k,t)? or what does it mean?
Also, why I can't change the polynomial arg.? , an error arise while changing this arg,
"can't change this argument,bad parameter?

@cburkert
Copy link
Owner Author

@lolib11 The argument specifies which polynomial is used for the BCH code.
As you can see in the code, it is directly passed to bchlib. So I suggest you go there for more information about what are valid polynomials and how to select them.
https://github.com/jkent/python-bchlib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants