Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch/Update to other HUNTRESS Implementation #127

Closed
1 task
gordonkoehn opened this issue Jul 26, 2023 · 5 comments · Fixed by #128
Closed
1 task

Switch/Update to other HUNTRESS Implementation #127

gordonkoehn opened this issue Jul 26, 2023 · 5 comments · Fixed by #128
Assignees

Comments

@gordonkoehn
Copy link
Collaborator

gordonkoehn commented Jul 26, 2023

It has been discovered that the scphylo implementation does fail silently when running it with multiple threads as essential for larger cell-mutation profiles.

This has been confirmed by the developers.

The issue has been addressed by the developers - and we shall update our scphylo dependency.

  • check why @pawel-czyz did a fork to start with / Why did we remove the numba dependency?
@gordonkoehn
Copy link
Collaborator Author

I'll try to just update the package for now.

@gordonkoehn
Copy link
Collaborator Author

Just updating to the newest version of scyphlo works when downgrading nextworkX, but I get trouble with numpy and numba - I am not sure why, something about a long not being defined.

Perhaps passing variables back to my numpy environment brings trouble - really don't know. Let's try to do a fork like @pawel-czyz did on my own, removing netwrokX and numba again.

@gordonkoehn
Copy link
Collaborator Author

gordonkoehn commented Jul 26, 2023

Make my own fork removing mamba and unpinning the networkX version. All tests work.

@gordonkoehn
Copy link
Collaborator Author

HUNTRESS indeed seems to work for multiple threads here.

  • Test 8 cores 16 GB ram locally for 1000 cells and 10 mutations.

@gordonkoehn
Copy link
Collaborator Author

Merge before testing. - Try in HPC EULER.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant