You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Unless there is a specific reason for concern about this, it seems like busy work.
The node software should never panic unintentionally. This includes explicit panic! and also .expect .unwrap assert! and similar behaviors that panic under the hood.
It should already be the case that existing code respects this. It should already be the case that the code reviews of newly added code police for this and not allow such behavior to be introduced.
As a due diligence exercise we can re-review for this when the 2.0 feature branch is merged to dev prior to cutting the final release.
Discover all of the panics for expect asserts, the trie store , EE etc and change all of them to error returns
The text was updated successfully, but these errors were encountered: