Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike Story: Discover the panics and address them #4825

Open
cspramit opened this issue Aug 7, 2024 · 1 comment
Open

Spike Story: Discover the panics and address them #4825

cspramit opened this issue Aug 7, 2024 · 1 comment

Comments

@cspramit
Copy link
Contributor

cspramit commented Aug 7, 2024

Discover all of the panics for expect asserts, the trie store , EE etc and change all of them to error returns

@EdHastingsCasperAssociation
Copy link
Collaborator

Unless there is a specific reason for concern about this, it seems like busy work.

The node software should never panic unintentionally. This includes explicit panic! and also .expect .unwrap assert! and similar behaviors that panic under the hood.

It should already be the case that existing code respects this. It should already be the case that the code reviews of newly added code police for this and not allow such behavior to be introduced.

As a due diligence exercise we can re-review for this when the 2.0 feature branch is merged to dev prior to cutting the final release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants