Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic ObservableObjects should be avoided when other classes exist #43

Open
ajnelson-nist opened this issue Mar 13, 2024 · 1 comment
Open

Generic ObservableObjects should be avoided when other classes exist #43

ajnelson-nist opened this issue Mar 13, 2024 · 1 comment

Comments

@ajnelson-nist
Copy link
Member

example.py currently yields some graph nodes typed as uco-observable:ObservableObject without further subtyping.

More specific classes should be used when available. However, this might require a less manual maintenance method for aligning the Python class structure with the ontology.
@ajnelson-nist ajnelson-nist mentioned this issue Mar 13, 2024
Merged
@ajnelson-nist
Copy link
Member Author

E.g., this:

CASE-Mapping-Python/example.py

Line 36 in 1cfd9b0

device_camera = uco.observable.ObservableObject()

should be replaced with:

device_camera = uco.observable.Device()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ajnelson-nist