From 5177ebbe2a786b03957f05c48b56aba29cec5d29 Mon Sep 17 00:00:00 2001
From: David Blaikie <dblaikie@gmail.com>
Date: Mon, 26 Aug 2024 14:13:39 -0700
Subject: [PATCH] Fix crash when disabling debug info (#4249)

The source line debug info generation assumed that the function would
have debug info. Check for a non-null di_subprogram_ to ensure we are
emitting debug info for the function.

Rather than checking the di_builder_ - this way if we implement
`nodebug` function attributes, it'll fall out naturally (by creating a
null di_subprogram_) rather than having to come back and change this
from "is debug info enabled" to "is debug info enabled for this
function" later on.
---
 toolchain/lower/function_context.cpp          | 14 +++++++++-----
 toolchain/lower/testdata/debug/nodebug.carbon |  8 ++++++++
 2 files changed, 17 insertions(+), 5 deletions(-)

diff --git a/toolchain/lower/function_context.cpp b/toolchain/lower/function_context.cpp
index 2999fa77a8ffd..97639080dcef0 100644
--- a/toolchain/lower/function_context.cpp
+++ b/toolchain/lower/function_context.cpp
@@ -97,10 +97,12 @@ auto FunctionContext::LowerInst(SemIR::InstId inst_id) -> void {
   auto inst = sem_ir().insts().Get(inst_id);
   CARBON_VLOG() << "Lowering " << inst_id << ": " << inst << "\n";
   builder_.getInserter().SetCurrentInstId(inst_id);
-  auto loc = file_context_->GetDiagnosticLoc(inst_id);
-  builder_.SetCurrentDebugLocation(
-      llvm::DILocation::get(builder_.getContext(), loc.line_number,
-                            loc.column_number, di_subprogram_));
+  if (di_subprogram_) {
+    auto loc = file_context_->GetDiagnosticLoc(inst_id);
+    builder_.SetCurrentDebugLocation(
+        llvm::DILocation::get(builder_.getContext(), loc.line_number,
+                              loc.column_number, di_subprogram_));
+  }
 
   CARBON_KIND_SWITCH(inst) {
 #define CARBON_SEM_IR_INST_KIND(Name)            \
@@ -112,7 +114,9 @@ auto FunctionContext::LowerInst(SemIR::InstId inst_id) -> void {
   }
 
   builder_.getInserter().SetCurrentInstId(SemIR::InstId::Invalid);
-  builder_.SetCurrentDebugLocation(llvm::DebugLoc());
+  if (di_subprogram_) {
+    builder_.SetCurrentDebugLocation(llvm::DebugLoc());
+  }
 }
 
 auto FunctionContext::GetBlockArg(SemIR::InstBlockId block_id,
diff --git a/toolchain/lower/testdata/debug/nodebug.carbon b/toolchain/lower/testdata/debug/nodebug.carbon
index 7f1e304b6698c..d7c25618baf55 100644
--- a/toolchain/lower/testdata/debug/nodebug.carbon
+++ b/toolchain/lower/testdata/debug/nodebug.carbon
@@ -10,5 +10,13 @@
 // TIP: To dump output, run:
 // TIP:   bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/lower/testdata/debug/nodebug.carbon
 
+fn F() {
+}
+
 // CHECK:STDOUT: ; ModuleID = 'nodebug.carbon'
 // CHECK:STDOUT: source_filename = "nodebug.carbon"
+// CHECK:STDOUT:
+// CHECK:STDOUT: define void @F() {
+// CHECK:STDOUT: entry:
+// CHECK:STDOUT:   ret void
+// CHECK:STDOUT: }