Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tearsheet design: VerticalPosition #6428

Open
1 of 5 tasks
Tracked by #6127
RichKummer opened this issue Nov 13, 2024 · 0 comments
Open
1 of 5 tasks
Tracked by #6127

Tearsheet design: VerticalPosition #6428

RichKummer opened this issue Nov 13, 2024 · 0 comments

Comments

@RichKummer
Copy link

RichKummer commented Nov 13, 2024

CreateTearsheet retains a prop for verticalPosition that determines how far from the top of the window the CreateTearsheet should begin. This was deprecated for tearsheet and was intended to be deprecated for Create. Verify if this is still valid – should we deprecate in Create and use same default spacing? Or, allow both tearsheet and CreateTearsheet to use this prop again?

  • Check Telemetry data for prop usage in CreateTearsheet
  • Research if this prop is necessary (can teams override if needed?)
  • Should CreateTearsheet and Tearsheet both have the verticalPosition prop, with the same default value?
  • Should we fully deprecate the verticalPosition prop in CreateTearsheet?
  • Discuss with development

Telemetry data as of 11/13/24

Image

Findings

  • CreateTearsheet is used in 1,883 repos.
  • VerticalPosition appears in both Tearsheet and CreateTearsheet according to Telemetry, but is only defined in 12 repos.
  • The normal value is used in 9 repos, while lower is used in 3. VerticalPosition is only referenced in 12 repos overall.
@github-project-automation github-project-automation bot moved this to Needs triage 🧐 in Carbon for IBM Products Nov 13, 2024
@RichKummer RichKummer changed the title Tearsheet design exploration: Vertical position Tearsheet design: VerticalPosition Nov 13, 2024
@oliviaflory oliviaflory moved this from Needs triage 🧐 to Needs refinement 🤓 in Carbon for IBM Products Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs refinement 🤓
Development

No branches or pull requests

2 participants