Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Clickable Tile icon is 16px in Storybook and 20px in Figma #17776

Open
2 tasks done
skcele opened this issue Oct 16, 2024 · 1 comment · May be fixed by #18068
Open
2 tasks done

[Bug]: Clickable Tile icon is 16px in Storybook and 20px in Figma #17776

skcele opened this issue Oct 16, 2024 · 1 comment · May be fixed by #18068
Assignees
@emyarod
Labels
component: tile package: @carbon/react @carbon/react role: dev 🤖 severity: 3 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@skcele
Copy link

skcele commented Oct 16, 2024

Package

@carbon/react

Browser

Chrome

Package version

1.68.0

Description

This is such a minor visual bug, but I noticed while fixing a similar visual issue with one of our components.

Clickable Tile's icon in the lower right is 16px in code (in Storybook at least) and 20px in Figma.

Screenshots

Figma
Image

Storybook
Image

Steps to reproduce

Use the Figma Component, set to Clickable, inspect in dev mode

Use the coded component in React and inspect.

Code of Conduct
@alina-jacob alina-jacob moved this to ⏱ Backlog in Design System Oct 17, 2024
@alina-jacob
Copy link
Member

Thanks for opening the issue @skcele, as per the design spec for clickable tile, the icon should be 20px
Image

So the code needs fixing!

@alisonjoseph alisonjoseph added the severity: 3 https://ibm.biz/carbon-severity label Oct 17, 2024
@emyarod emyarod self-assigned this Nov 4, 2024
@emyarod emyarod linked a pull request Nov 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emyarod emyarod

Labels
component: tile package: @carbon/react @carbon/react role: dev 🤖 severity: 3 https://ibm.biz/carbon-severity type: bug 🐛
Projects
Design System
Status: 🚦 In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tile): update clickable tile icon size and spacing emyarod/carbon
4 participants
@alisonjoseph @emyarod @skcele @alina-jacob