Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooltip] Doc update on Usage tab #4441

Open
4 tasks done
Tracked by #3956
thyhmdo opened this issue Jan 24, 2025 · 0 comments · May be fixed by #4448
Open
4 tasks done
Tracked by #3956

[Tooltip] Doc update on Usage tab #4441

thyhmdo opened this issue Jan 24, 2025 · 0 comments · May be fixed by #4448

Comments

@thyhmdo
Copy link
Member

thyhmdo commented Jan 24, 2025

Currently, we can't use IconButton or Button hasIconOnly because they use Tooltip internally and the story code wouldn't actually show how to use a Tooltip.

Slack thread


01/27/25

Discussed with Mike Gower and Taylor Jones. Tooltips should be integrated with other components (icon button, tab with icons, copy button,...) in the code. If not, there should be an issue to fix these bugs. This leaves only DefinitionTooltip as one variant of Tooltip. Mike suggested that the tooltip could be a pattern as well.


Usage tab

  • De-emphasize Standard and Icon button Tooltips while leaving Definition Tooltip as one variant in this template
  • Make sure to pair documentation about tooltip of other components on the storybook
  • Leaving images for IconButton tooltip is ok
  • Update some outdated info (interactions for definition tooltip)
@thyhmdo thyhmdo changed the title Update or create issues to make any changes to toggletip and tooltip, link them here? Doc update on toggletip and tooltip Jan 24, 2025
@thyhmdo thyhmdo self-assigned this Jan 27, 2025
@thyhmdo thyhmdo moved this to 🏗 In Progress in Design System Jan 27, 2025
@laurenmrice laurenmrice added this to the 2025 1H milestone Jan 28, 2025
@thyhmdo thyhmdo changed the title Doc update on toggletip and tooltip Doc update on Usage tab Jan 28, 2025
@thyhmdo thyhmdo linked a pull request Jan 28, 2025 that will close this issue
@thyhmdo thyhmdo changed the title Doc update on Usage tab [Tooltip] Doc update on Usage tab Jan 29, 2025
@thyhmdo thyhmdo moved this from 🏗 In Progress to 🚦 In Review in Design System Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🚦 In Review
Development

Successfully merging a pull request may close this issue.

2 participants