Incorrect use of catch unreachable

[tauoverpi]

https://github.com/search?q=repo%3Acapy-ui%2Fcapy%20unreachable&type=code

The majority of cases of unreachable within this codebase are not correct and introduce undefined behaviour upon failure which is catastrophic for consumers of this library as if any of the operations fail the program could do anything (even play a game of tetris or fire all missiles). If the intent was to @panic() then such should be done explicitly or where the user should handle error, an error union.

https://ziglang.org/documentation/master/#unreachable

In ReleaseFast and ReleaseSmall mode, the optimizer uses the assumption that unreachable code will never be hit to perform optimizations.

https://ziglang.org/documentation/master/#Reaching-Unreachable-Code

Additional reading:

• http://blog.llvm.org/2011/05/what-every-c-programmer-should-know.html (the series)

[zenith391]

Yes you're right. I did end up using catch unreachable a bit too liberally while prototyping and forgot to remove them when commiting. Over time.. it accumulates