CookieSameSiteEnum is not exported by happy-dom

[Spixmaster]

v16.6.0

CookieSameSiteEnum is not exported by happy-dom. It is needed for .cookieContainer.addCookies().

import {CookieSameSiteEnum} from "happy-dom";

[capricorn86]

Thank you for reporting @Spixmaster! 🙂

This has been fixed now in v16.7.1.

I have also made non-mandatory cookie properties optional in CookieContainer.addCookies().

[Spixmaster]

Thank you very much, @capricorn86 !

CookieSameSiteEnum is exported now.

From my side, the optional properties are not optional. The source code runs with only mandatory properties given but TypeScript complains about missing properties.

import {Browser, type BrowserContext, type BrowserPage} from "happy-dom";

const browser: Browser = new Browser({
    settings: {
        disableErrorCapturing: true,
        disableJavaScriptEvaluation: true
    }
});
const context: BrowserContext = browser.defaultContext;
context.cookieContainer.addCookies([{
    key: "session",
    originURL: new URL("http://localhost:5285"),
    value: "123456"
}]);

Output from the TypeScript language server:

Type '{ key: string; originURL: URL; value: string; }' is missing the following properties from type 'ICookie': domain, path, expires, httpOnly, and 2 more. (FixIt)

[Spixmaster]

I am not that proficient in TypeScript but it seems to me that the JSON object here misses the declaration as optional.

[Spixmaster]

I just took a look at the commit 02130fb.

If I understand correcty, there is a distinction between IOptionalCookie and ICookie. I do not understand the reason for that. However, addCookies() has the data type ICookie as the first parameter. Maybe it should have IOptionalCookie instead?

[arpowers]

FYI this broke our build with
Error: Failed to execute 'addCookies' on 'CookieContainer': The properties 'key' and 'originURL' are required.

code in question:

 beforeEach(() => {
    // Clear cookies and local/session storage before each test
    document.cookie.split(';').forEach((cookie) => {
      document.cookie = cookie.replace(/^ +/, '').replace(/=.*/, `=;expires=${new Date(0).toUTCString()};path=/`)
    })
    localStorage.clear()
    sessionStorage.clear()
  })

[capricorn86]

@arpowers I reverted the error check and it will ignore invalid cookies instead (for now at least)

@Spixmaster I have added IOptionalCookie to the ICookieContainer as well now, so it should be correct now