Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: /security/fips redesign #14694

Open
wants to merge 3 commits into
base: feature-security-bubble
Choose a base branch
from

Conversation

mtruj013
Copy link
Contributor

@mtruj013 mtruj013 commented Jan 30, 2025

Done

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-12035, #14633

@webteam-app
Copy link

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feature-security-bubble@a906ef4). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             feature-security-bubble   #14694   +/-   ##
==========================================================
  Coverage                           ?   72.32%           
==========================================================
  Files                              ?      120           
  Lines                              ?     3404           
  Branches                           ?     1177           
==========================================================
  Hits                               ?     2462           
  Misses                             ?      917           
  Partials                           ?       25           

@mtruj013 mtruj013 changed the title Apply page redesign feat: /security/fips redesign Jan 30, 2025
@mtruj013 mtruj013 changed the base branch from main to feature-security-bubble January 30, 2025 13:57
@eliman11
Copy link

eliman11 commented Jan 30, 2025

Thanks @mtruj013! Comments:

  • US spelling: optimised -> optimized in "...preconfigured with FIPS 140 certified packages optimised for the cloud."
  • Could we remove "140-3" from the button to keep it consistent with the previous section
Screenshot 2025-01-30 at 17 58 35
  • Under "Certified packages under FIPS 140-3" we're missing the "libgcrypt" row
Screenshot 2025-01-30 at 18 10 52
  • Henry's left a suggestion on the copydoc to remove that last "FIPS 140-3 and Ubuntu" section at the bottom

  • Sorry this wasn't on the design before but could we add the webinar link next to the contact us button

Screenshot 2025-01-30 at 18 04 14
  • Could we hide the hero image on smaller screens? Or maybe there's a workaround @mattea-turic can suggest on how it resizes
Screenshot 2025-01-30 at 18 14 03

@mattea-turic
Copy link
Collaborator

Thanks @mtruj013 !

Just one thing:

  • As @eliman11 mentioned, maybe we hide the nist logo on smaller screens? It doesn't really add much so I think it's fine to omit it there

All else is good, so I'll +1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants