-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Rebrand /kubernetes index page #14683
feat: Rebrand /kubernetes index page #14683
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## k8s-bubble-refresh #14683 +/- ##
===================================================
Coverage 72.58% 72.58%
===================================================
Files 120 120
Lines 3392 3392
Branches 1169 1174 +5
===================================================
Hits 2462 2462
Misses 906 906
Partials 24 24 |
d26569d
to
b8c308c
Compare
b69208d
to
38ed43c
Compare
Thanks @britneywwc! Mostly super minor copy changes -
|
Thanks @eliman11, I have applied those changes. Can you take another look please |
Thanks @britneywwc ! A few notes: For "Why choose Canonical Kubernetes Platform?"
For "Public cloud Kubernetes powered by Ubuntu"
For "Integrated cluster management platforms"
For "Bootstrap your Kubernetes journey":
![]() |
I think this might be from the logo's used, I can see in the code that some are marked with [DEPRECATED]. Could you add the appropriate logos to the asset manager tag https://assets.ubuntu.com/manager?tag=kubernetes-landing pls
I am only able to replicate this when I double click |
Thanks @petesfrench! Adding UX+1 |
@petesfrench I'm good w/giving design +1! Just if you could double-check about the toggle on Mac. The bug(?) is more dramatic on safari than chrome: ![]() |
@mattea-turic with the help of @mtruj013 I was able to push a fix. Can you take another look to make sure it works as expected? |
@petesfrench @mtruj013 yes it does, thank you both! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, two small comments to clean up. But a11y tests are good and performance is 91%. Nice work 👍
Thanks @anthonydillon, can you put a QA & code +1 if you are happy for us to merge please |
Sorry GH was having trouble when I reviewed it. Applied them now. |
* Rebrand /k8s index page * Add card with toggle functionality * refactor: Apply changes from ux review * refactor: Apply changes from design review * refactor: Update logo section * fix: clicking the 'discover' toggle no longer highlights the label text * feat: Add an aria label to discover pro toggle --------- Co-authored-by: Peter French <[email protected]>
Done
QA
Issue / Card
Fixes WD-12944
Screenshots
[If relevant, please include a screenshot.]
Help
QA steps - Commit guidelines