Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rebrand /kubernetes index page #14683

Merged
merged 7 commits into from
Jan 31, 2025

Conversation

britneywwc
Copy link
Contributor

@britneywwc britneywwc commented Jan 28, 2025

Done

  • Apply rebranding for /kubernetes landing page

QA

Issue / Card

Fixes WD-12944

Screenshots

[If relevant, please include a screenshot.]

Help

QA steps - Commit guidelines

@webteam-app
Copy link

@britneywwc britneywwc marked this pull request as draft January 28, 2025 00:43
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.58%. Comparing base (3eb970c) to head (1d2ae71).
Report is 2 commits behind head on k8s-bubble-refresh.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           k8s-bubble-refresh   #14683   +/-   ##
===================================================
  Coverage               72.58%   72.58%           
===================================================
  Files                     120      120           
  Lines                    3392     3392           
  Branches                 1169     1174    +5     
===================================================
  Hits                     2462     2462           
  Misses                    906      906           
  Partials                   24       24           

@britneywwc britneywwc marked this pull request as ready for review January 28, 2025 11:10
@petesfrench petesfrench self-assigned this Jan 28, 2025
@eliman11
Copy link

eliman11 commented Jan 28, 2025

Thanks @britneywwc! Mostly super minor copy changes -

  • Delete periods at the end of bullet points under "Why choose Canonical Kubernetes Platform?"
  • Delete period at the end of the bullet point "Optimized for performance, boot speed, and drivers on all major public clouds"
  • Text under "Kubernetes Explorer" should be "Three-day Kubernetes training to ramp up your team’s skills, including:"
  • Text under "Kubernetes Discoverer Plus" should be "Three-week custom architecture deployment project and knowledge transfer, including:"
  • "Bare Metal" under "Kubernetes Discoverer Plus" should link to https://maas.io/
  • "Optimize your ML workloads on Kubernetes" should link to https://ubuntu.com/engage/optimise-ml-workloads-on-kubernetes
  • Delete the period at the end of "Contact us" at the bottom
  • Add alt text to logo cloud under "Public cloud Kubernetes powered by Ubuntu"
  • Change "MicroK8s", "Charmer Kubernetes" and "Kubernetes with Kubeadm" to h4s without changing styling
  • Change "What's included" headings under the options block into h4s without changing styling

@petesfrench
Copy link
Contributor

Thanks @eliman11, I have applied those changes. Can you take another look please

@mattea-turic
Copy link
Collaborator

mattea-turic commented Jan 29, 2025

Thanks @britneywwc ! A few notes:

For "Why choose Canonical Kubernetes Platform?"

  • Could you add a break after "choose" in the h2 pls?

For "Public cloud Kubernetes powered by Ubuntu"

  • Could you add a break after "Kubernetes"?
  • The logo section also looks a little off in that the logos seem to be wrapped in a container that causes excess horizontal whitespace?

For "Integrated cluster management platforms"

  • Could you add a break after "Integrated"?

For "Bootstrap your Kubernetes journey":

  • Not sure if much can be done here, but when clicking the toggle, the text to the right gets selected too
Screenshot 2025-01-29 at 09 16 30

@petesfrench
Copy link
Contributor

petesfrench commented Jan 29, 2025

@mattea-turic

The logo section also looks a little off in that the logos seem to be wrapped in a container that causes excess horizontal whitespace?

I think this might be from the logo's used, I can see in the code that some are marked with [DEPRECATED]. Could you add the appropriate logos to the asset manager tag https://assets.ubuntu.com/manager?tag=kubernetes-landing pls

Not sure if much can be done here, but when clicking the toggle, the text to the right gets selected too

I am only able to replicate this when I double click

@eliman11
Copy link

Thanks @petesfrench! Adding UX+1

@mattea-turic
Copy link
Collaborator

@petesfrench I'm good w/giving design +1! Just if you could double-check about the toggle on Mac. The bug(?) is more dramatic on safari than chrome:

Screenshot 2025-01-30 at 02 07 37

@petesfrench
Copy link
Contributor

@mattea-turic with the help of @mtruj013 I was able to push a fix. Can you take another look to make sure it works as expected?

@mattea-turic
Copy link
Collaborator

@petesfrench @mtruj013 yes it does, thank you both! :)

@anthonydillon anthonydillon self-assigned this Jan 30, 2025
Copy link
Contributor

@anthonydillon anthonydillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two small comments to clean up. But a11y tests are good and performance is 91%. Nice work 👍

templates/kubernetes/index.html Show resolved Hide resolved
templates/kubernetes/index.html Outdated Show resolved Hide resolved
@petesfrench
Copy link
Contributor

Thanks @anthonydillon, can you put a QA & code +1 if you are happy for us to merge please

@anthonydillon
Copy link
Contributor

Sorry GH was having trouble when I reviewed it. Applied them now.

@petesfrench petesfrench merged commit 10d7bd5 into canonical:k8s-bubble-refresh Jan 31, 2025
15 checks passed
@britneywwc britneywwc deleted the k8s-landing branch February 3, 2025 03:59
mtruj013 pushed a commit that referenced this pull request Feb 4, 2025
* Rebrand /k8s index page

* Add card with toggle functionality

* refactor: Apply changes from ux review

* refactor: Apply changes from design review

* refactor: Update logo section

* fix: clicking the 'discover' toggle no longer highlights the label text

* feat: Add an aria label to discover pro toggle

---------

Co-authored-by: Peter French <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants