Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gui launch bridged error #3897

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix gui launch bridged error #3897

wants to merge 4 commits into from
+35 −15

Conversation

andrei-toterman
Copy link
Contributor

This PR introduces the following changes:

  • when launching an instance with some mounts specified, if the reply stream of the launch RPC yielded an error, the launch operation would not end early, and it would proceed to attempt the mounts. now, instead of yielding directly from the launch reply stream, we use await for to iterate over the stream and manually yield the replies. this turns errors from the stream into exceptions that are thrown, interrupting the launch process early, so mounts are no longer attempted
  • we now allow our custom Switch to be conditionally disabled. there were also some minor changes to it, related to using newer styling properties in place of deprecated ones, with no effect to visuals
  • in the launch form, we check if a bridged network was set correctly, and if not, we disable the switch for connecting to the bridged network, with an appropriate message
  • we now allow un-setting the bridged network from the Settings page, by introducing a 'None' option, equivalent to multipass set local.bridged-network=''

fix #3881
MULTI-1764

@codecov Codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.07%. Comparing base (637e431) to head (b6fdf74).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3897      +/-   ##
==========================================
- Coverage   89.08%   89.07%   -0.01%     
==========================================
  Files         254      254              
  Lines       14598    14598              
==========================================
- Hits        13004    13003       -1     
- Misses       1594     1595       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

levkropp
levkropp approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@levkropp levkropp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after changing
Once connection is established, you won't be able to unset it.
to
Once established, you won't be able to unset it.
or
You won't be able to unset the connection once it is established.
or something along those lines
settings work on my end!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levkropp levkropp levkropp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create instance with bridged network: instance <name> does not exist
2 participants
@andrei-toterman @levkropp