Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some charm builds break due to NodeJS v12 in Jammy-based runners #236

Open
alnvdl-work opened this issue Mar 1, 2024 · 1 comment
Open

Comments

@alnvdl-work
Copy link

alnvdl-work commented Mar 1, 2024

Bug Description

The charmcraft templates use pyright for running static type checks on the charm.

However, pyright >= 1.1.352 does not work with NodeJS v12, that ships with Ubuntu 22.04. See: microsoft/pyright#7365

The workaround we found is pinning pyright in tox.ini:

deps =
    pyright==1.1.351

But that's unfortunately not a viable long-term solution, since NodeJS v12 has been unsupported for a long time now.

We did not install NodeJS in our workflows, so I'm assuming it's coming from the runners setup by this charm, correct?

Would it be possible to source NodeJS in the runners from a different, more up-to-date source (e.g., a snap)?

To Reproduce

Try to run tox on any charm that follows the charmcraft templates or uses pyright.

Environment

Official IS-maintained GitHub runners.

Relevant log output

-

Additional context

No response

@cbartz
Copy link
Collaborator

cbartz commented Mar 4, 2024

It seems we have to update node on the image to match the gh hosted ones: https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#language-and-runtime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants