Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library publishing workflow doesn't like LIBAPI changes #97

Open
jnsgruk opened this issue May 26, 2023 · 0 comments
Open

Library publishing workflow doesn't like LIBAPI changes #97

jnsgruk opened this issue May 26, 2023 · 0 comments
Labels
Status: Triage Type: Bug Something isn't working

Comments

@jnsgruk
Copy link
Member

jnsgruk commented May 26, 2023

Bug Description

Recently the snap library was bumped to v2 in canonical/operator-libs-linux#92.

The CI didn't seem to catch that, which you can see here

To Reproduce

Update a library LIBAPI version, moving the file into the new version

Environment

operator-libs-linux repo

Relevant log output

/usr/bin/sudo snap install charmcraft --classic --channel latest/stable
charmcraft 2.3.0 from Canonical** installed
/snap/bin/charmcraft list-lib operator-libs-linux --format=json
[
    {
        "charm_name": "operator-libs-linux",
        "library_name": "apt",
        "library_id": "7c3dbc9c2ad44a47bd6fcb25caa270e5",
        "api": 0,
        "patch": 11,
        "content_hash": "e16de26b23a6b35ef565c99d49d511f3e781b8d56a58a6f1edf2f4e0e3f6f3a4"
    },
    {
        "charm_name": "operator-libs-linux",
        "library_name": "dnf",
        "library_id": "1e93f444444d4a4a8df06c1c16b33aaf",
        "api": 0,
        "patch": 1,
        "content_hash": "c030c118a493f355fca303f07ca4795598f708d8931af0d9b4aa1eee92156880"
    },
    {
        "charm_name": "operator-libs-linux",
        "library_name": "passwd",
        "library_id": "cf7655b2bf914d67ac963f72b930f6bb",
        "api": 0,
        "patch": 4,
        "content_hash": "441ad5d92530c227a78e2207f5650f86a8b842134545e222514b3d6425ed9673"
    },
    {
        "charm_name": "operator-libs-linux",
        "library_name": "snap",
        "library_id": "05394e5893f94f2d90feb7cbe6b633cd",
        "api": 1,
        "patch": 12,
        "content_hash": "ab4190b96a2bddfa60caf1c14a74868f378b5243396e6e4a2b6604c6b9b10976"
    },
    {
        "charm_name": "operator-libs-linux",
        "library_name": "systemd",
        "library_id": "045b0d179f6b4514a8bb9b48aee9ebaf",
        "api": 1,
        "patch": 3,
        "content_hash": "56e0dad863d86816ef55ac1fae4f61a42d8d66a73d49620ea8d6768282480575"
    }
]
found lib file: ./lib/charms/operator_libs_linux/v0/apt.py. Parsing...
found lib file: ./lib/charms/operator_libs_linux/v0/dnf.py. Parsing...
found lib file: ./lib/charms/operator_libs_linux/v0/passwd.py. Parsing...
found lib file: ./lib/charms/operator_libs_linux/v1/systemd.py. Parsing...
found lib file: ./lib/charms/operator_libs_linux/v2/snap.py. Parsing...
checking status for apt
remote lib: {"libName":"apt","version":0,"revision":11}
apt and apt are equal
checking status for dnf
remote lib: {"libName":"dnf","version":0,"revision":1}
dnf and dnf are equal
checking status for passwd
remote lib: {"libName":"passwd","version":0,"revision":4}
passwd and passwd are equal
checking status for systemd
remote lib: {"libName":"systemd","version":1,"revision":3}
systemd and systemd are equal
checking status for snap
remote lib: {"libName":"snap","version":1,"revision":12}
snap has a lower version or revision than snap
Errors found during lib comparison.
Nothing to update. Exiting...


### Additional context

_No response_
@jnsgruk jnsgruk added Type: Bug Something isn't working Status: Triage labels May 26, 2023
MiaAltieri added a commit to canonical/mongodb-operator that referenced this issue Oct 13, 2023
## Issue
Libraries will begin diverging for `5/edge` and `6/edge`

## Solution
create separate `LIB API` for `6/edge`

## Known issues with Charming Actions
Currently [charming actions does not support publishing/checking major
libapi](canonical/charming-actions#97), for
this PR comment out the checks and manually publish libs on merge. In
theory, we can comment them back in and have the workflows work again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant