You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are runningcheck-libraries on PRs to make sure our charms are using the latest shared libraries.
The approach with green/red labels works perfectly: example.
What is missing is a human protection to inform author about forgotten LIBPATCH bump on the shared library change: example.
What about to set red label: Libraries: bump LIBPATCH if author changes shared library and forget to bump it?
At the moment the action simply prints notice and sets green label Libraries: OK:
Library charms.mongodb.v0.helpers has local changes, cannot be updated.
Library charms.mongodb.v0.mongodb_backups has local changes, cannot be updated.
Library charms.mongodb.v0.mongodb_vm_legacy_provider has local changes, cannot be updated.
We have tried to use optionfail-build, but it didn't fail on locally changed library.
Is it a broken option or it was designed for something else? Tnx!
The text was updated successfully, but these errors were encountered:
Enhancement Proposal
Hi,
We are running
check-libraries
on PRs to make sure our charms are using the latest shared libraries.The approach with green/red labels works perfectly: example.
What is missing is a human protection to inform author about forgotten LIBPATCH bump on the shared library change: example.
What about to set red label:
Libraries: bump LIBPATCH
if author changes shared library and forget to bump it?At the moment the action simply prints notice and sets green label
Libraries: OK
:We have tried to use option
fail-build
, but it didn't fail on locally changed library.Is it a broken option or it was designed for something else? Tnx!
The text was updated successfully, but these errors were encountered: