Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to post comment #177

Closed
nicolasbock opened this issue Jul 31, 2024 · 3 comments
Closed

Failed to post comment #177

nicolasbock opened this issue Jul 31, 2024 · 3 comments
Assignees
@nicolasbock
Labels
bug Something isn't working

Comments

@nicolasbock
Copy link
Collaborator

After some time the Salesforce session ID expires and Athena fails to post comments to cases. The trace of this behavior in the log is

2024-07-14 18:11:11 [info]: Processing comment for case 500N100000EiSQLIA3
2024/07/14 18:11:11 [simpleforce] request failed, 401
2024/07/14 18:11:11 [simpleforce] Failed resp.body:  [{"message":"Session expired or invalid","errorCode":"INVALID_SESSION_ID"}]
2024/07/14 18:11:11 [simpleforce] failed to process http request, [simpleforce] Error. http code: 401 Error Message:  Session expired or invalid Error Code: INVALID_SESSION_ID
2024-07-14 18:11:11 [error]: Failed to post comment to case id: 500N100000EiSQLIA3
2024-07-14 18:11:11 [info]: Successfully posted comment on case 500N100000EiSQLIA3 for 1 reports

Athena should notice such failures and try a little harder to recover. At the very least, the comment that was going to be posted should be stored so that it can be posted once the connection is restored.
@nicolasbock nicolasbock added the bug Something isn't working label Jul 31, 2024
@syncronize-issues-to-jira Syncronize issues to Jira
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/SET-936.

This message was autogenerated

@xmkg
Copy link

xmkg commented Aug 1, 2024

The last log line is interesting:

Successfully posted comment on case 500N100000EiSQLIA3 for 1 reports

It seems like athena somehow thinks it successfully posted a comment where it didn't.

@nicolasbock nicolasbock self-assigned this Aug 6, 2024
nicolasbock added a commit to nicolasbock/athena-core that referenced this issue Sep 12, 2024
@nicolasbock
Do not re-use connections
648d184 
In order to avoid stale connections to Salesforce and files.com, do not
re-use those connections (the clients) and rather create new client
connections when needed.

Issue: canonical#177
Signed-off-by: Nicolas Bock <[email protected]>
nicolasbock added a commit to nicolasbock/athena-core that referenced this issue Sep 13, 2024
@nicolasbock
Do not re-use connections
b7287c5 
Processor Edition

In order to avoid stale connections to Salesforce and files.com, do not
re-use those connections (the clients) and rather create new client
connections when needed.

Issue: canonical#177
Signed-off-by: Nicolas Bock <[email protected]>
nicolasbock added a commit to nicolasbock/athena-core that referenced this issue Sep 13, 2024
@nicolasbock
Do not re-use connections
d254d5b 
Processor Edition

In order to avoid stale connections to Salesforce and files.com, do not
re-use those connections (the clients) and rather create new client
connections when needed.

Issue: canonical#177
Signed-off-by: Nicolas Bock <[email protected]>
@nicolasbock
Copy link
Collaborator Author

This is hopefully fixed now with #198 and #189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolasbock nicolasbock

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicolasbock @xmkg