Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove can-ajax import inside data-url behavior #445

Open
DesignByOnyx opened this issue Nov 30, 2018 · 2 comments
Open

Remove can-ajax import inside data-url behavior #445

DesignByOnyx opened this issue Nov 30, 2018 · 2 comments

Comments

@DesignByOnyx
Copy link
Contributor

The data-url behavior allows you to pass a custom ajax transport. However, if a consumer decides to use their own transport for all connections, the can-ajax dependency is doesn't get shaken out of the deps tree due to the hard import in can-ajax.

I'm not sure how to best solve this, as each connection will be required to pass the desired ajax transport and would likely be a breaking change.

@justinbmeyer
Copy link
Contributor

Folks could make their own data-url if they really needed this. Might be worth keeping data-url working by default. can-ajax isn't that big.

@justinbmeyer
Copy link
Contributor

An alternative would be to make a data-url without the hard coding (data-ajax), but data-url basically extends data-ajax into data-url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants