[ISSUE] Connectors envFrom is empty when identity.auth is disabled (minimalist setup)

[p4tr0ckz]

Describe the issue:

Using this local setup values to test the latest helm chart version, deployment fails.

Expected behavior:

envFrom should be within the if within the template

How to reproduce:

Use latest Helm Chart Version and try deploying with minimalist values.

Logs:

Error: UPGRADE FAILED: cannot patch "camunda-connectors" with kind Deployment: Deployment.apps "camunda-connectors" is invalid: spec.template.spec.containers[0].env[1].valueFrom: Invalid value: "": may not be specified when valueis not empty
Environment:

• Platform: GCP
• Helm CLI version: 3.16.4
• Chart version: 8.6.0
• Values file: minimalist

I know this is one of those edge cases for people who dont want to use identity, but since youre providing a minimalistic testing setup, i just wanted to let you know :)

[p4tr0ckz]

I tried opening a PR for this but couldnt, so here is a suggestion for

camunda-platform-helm/charts/camunda-platform-8.6/templates/connectors/deployment.yaml
Line 95-102

          {{- if or .Values.global.identity.auth.enabled .Values.connectors.envFrom }}
          envFrom:
          {{- end }}
          {{- if .Values.global.identity.auth.enabled }}
            - configMapRef:
                name: {{ include "camundaPlatform.fullname" . }}-identity-env-vars
          {{- end }}
          {{- if .Values.connectors.envFrom -}}
            {{ .Values.connectors.envFrom | toYaml | nindent 12 }}
          {{- end }}