Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Force identity.auth.enable:true when multinenancy.enable:true #1151

Closed
pierre-yves-monnet opened this issue Dec 13, 2023 · 1 comment · Fixed by #1160
Closed
Assignees
Labels
kind/enhancement New feature or request kind/refactor size/xs Relative effort/time: Extra Small
Milestone

Comments

@pierre-yves-monnet
Copy link

Describe the use case:
When the user moves the cluster to a multi-tenancy, it must set the authentication to true.
Otherwise, we have a cluster in a terra incognita world, and logging/error does not help to figure out what the issue is.

Describe the enhancement/feature:

When values.yaml give
multinenancy.enable:true
then automatically, the helm chart force
identity.auth.enable:true

Desired outcome and acceptance tests:

@pierre-yves-monnet pierre-yves-monnet added the kind/enhancement New feature or request label Dec 13, 2023
@aabouzaid aabouzaid self-assigned this Dec 15, 2023
@aabouzaid aabouzaid added the size/xs Relative effort/time: Extra Small label Dec 15, 2023
@aabouzaid aabouzaid added this to the 8.4 release milestone Dec 15, 2023
@aabouzaid
Copy link
Member

@pierre-yves-monnet Thanks for reporting that 🙌
We avoid manipulating user input so I've added it to the constraints to fail the installation with a message with instructions to enable the requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request kind/refactor size/xs Relative effort/time: Extra Small
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants