Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tomcat to a version >= 10.1.25 and >= 9.0.90 #4533

Closed
4 tasks done
tasso94 opened this issue Aug 13, 2024 · 5 comments
Closed
4 tasks done

Update Tomcat to a version >= 10.1.25 and >= 9.0.90 #4533

tasso94 opened this issue Aug 13, 2024 · 5 comments
Assignees
Labels
type:task Issues that are a change to the project that is neither a feature nor a bug fix. version:7.19.15 version:7.20.8 version:7.21.4 version:7.22.0-alpha5 version:7.22.0

Comments

@tasso94
Copy link
Member

tasso94 commented Aug 13, 2024

Acceptance Criteria (Required on creation)

Update Tomcat to a version >= 10.1.25 and >= 9.0.90

Hints

Links

Breakdown

Pull Requests

Preview Give feedback

Dev2QA handover

  • Does this ticket need a QA test and the testing goals are not clear from the description? Add a Dev2QA handover comment
@joaquinfelici
Copy link
Contributor

joaquinfelici commented Aug 14, 2024

Hints for review

Hey @mboskamp

Fixes:

7.22

  • bumped spring-boot version for parent (used by both run and spring-boot-stater) from 3.3.0 to 3.3.1 (uses tomcat 10.1.25)
  • bumped tomcat version in parent from 9.0.89 to 9.0.90

7.21

  • bumped spring-bootversion for parent (used byspring-boot-starter) from 3.2.6 to 3.2.7 (uses tomcat 10.1.25)
  • bumped spring-boot version for run from 3.3.0 to 3.3.1 (uses tomcat 10.1.25)
  • bumped tomcat version in parent from 9.0.89 to 9.0.90

7.20

  • bumped spring-boot version for run from 3.2.6 to 3.2.7 (uses tomcat 10.1.25)
  • kept old spring-boot version (3.1.12 that uses tomcat 10.1.24) in parent but overrode tomcat version in spring-boot-starter to 10.1.25 for tomcat dependencies
  • bumped tomcat version in parent from 9.0.89 to 9.0.90

7.19

  • bumped tomcat version in parent from 9.0.89 to 9.0.90
  • kept old spring-boot version in parent (2.7.18 that uses tomcat 9.0.83) but:
  • for spring-boot-starter, tomcat dependencies versions are already overridden with this property (see here)
  • same for run (see here)

Note: This may not be 100% ready for merge but this needs to be delivered in next patch so I'd rather you take a look at it while I'm off. Thank you!

@mboskamp
Copy link
Member

mboskamp commented Aug 15, 2024

@joaquinfelici, I added some suggestions to the PRs.
Could you set the correct backport version labels on this issue?

@joaquinfelici
Copy link
Contributor

Hey @mboskamp , I applied your suggestions. The labels for the backport versions were already correctly set for next patch (end of august).

@mboskamp
Copy link
Member

Hi @joaquinfelici, thanks for implementing the suggestions.

What do you think about the CI failures (Distro EE)? This stage does not fail on the 7.21 and 7.20 branches. Maybe you can solve it by rebasing your PRs.

The version labels have the potential prefix. We are committed to delivering this change with the mentioned versions. In that case, we need the version:x.y.z etc. labels (e.g. version:7.19.15).

@joaquinfelici
Copy link
Contributor

Hey @mboskamp , I rebased and all jobs are green now, thanks.
And indeed for the labels, just changed them. Please review https://github.com/camunda/camunda-bpm-platform-maintenance/pull/1268.

hauptmedia added a commit to hauptmedia/operaton that referenced this issue Nov 4, 2024
camunda/camunda-bpm-platform#4533

Backported commit 5f44d4ff1b from the camunda-bpm-platform repository.
Original author: Joaquín <[email protected]>
javahippie pushed a commit to operaton/operaton that referenced this issue Nov 5, 2024
camunda/camunda-bpm-platform#4533

Backported commit 5f44d4ff1b from the camunda-bpm-platform repository.
Original author: Joaquín <[email protected]>
kthoms pushed a commit to kthoms/operaton that referenced this issue Nov 5, 2024
camunda/camunda-bpm-platform#4533

Backported commit 5f44d4ff1b from the camunda-bpm-platform repository.
Original author: Joaquín <[email protected]>
kthoms pushed a commit to kthoms/operaton that referenced this issue Nov 5, 2024
camunda/camunda-bpm-platform#4533

Backported commit 5f44d4ff1b from the camunda-bpm-platform repository.
Original author: Joaquín <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:task Issues that are a change to the project that is neither a feature nor a bug fix. version:7.19.15 version:7.20.8 version:7.21.4 version:7.22.0-alpha5 version:7.22.0
Projects
None yet
Development

No branches or pull requests

4 participants