Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where is item enchantment documentation? #524

Closed
NQNStudios opened this issue Jan 7, 2025 · 3 comments · Fixed by #547
Closed

Where is item enchantment documentation? #524

NQNStudios opened this issue Jan 7, 2025 · 3 comments · Fixed by #547
Labels
meta Related to the build system or other things other than the code question

Comments

@NQNStudios
Copy link
Collaborator

I was looking in the documentation for the 8 enchantment options as the scenario editor said they're in the docs. But I can't find them in the documentation anywhere that seems related/sensible. I found this list which shows a lot of things that also might make for interesting enchantments, but nothing about the 8 types.

I eventually found them in the code.

@NQNStudios NQNStudios added question meta Related to the build system or other things other than the code labels Jan 7, 2025
@NQNStudios
Copy link
Collaborator Author

It would also be easy enough to add a dialog for choosing the enchantment within the editor without checking the docs. Mage/Priest spells on items have such a dialog

@CelticMinstrel
Copy link
Member

I was looking in the documentation for the 8 enchantment options as the scenario editor said they're in the docs. But I can't find them in the documentation anywhere that seems related/sensible. I found this list which shows a lot of things that also might make for interesting enchantments, but nothing about the 8 types.

They're on this page, since originally the only place the enchantment options could be used was at a shop (I added the ability to place pre-enchanted items later on). That hasn't been updated for the recent new one(s) though.

It would also be easy enough to add a dialog for choosing the enchantment within the editor without checking the docs. Mage/Priest spells on items have such a dialog

Yes, that should definitely be done in the editor. I wouldn't be at all surprised if the list is already wired up in the talk node edit dialog and it was just missed in the placed item edit dialog.

@NQNStudios NQNStudios changed the title Where is iem enchantment documentation? Where is item enchantment documentation? Jan 8, 2025
@CelticMinstrel
Copy link
Member

I wouldn't be at all surprised if the list is already wired up in the talk node edit dialog and it was just missed in the placed item edit dialog.

Looks like it's the other way around. The list is used when editing a placed item but not when editing a dialogue node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to the build system or other things other than the code question
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants