Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve TODO comments in the source code #400

Open
CelticMinstrel opened this issue Aug 10, 2024 · 2 comments
Open

Resolve TODO comments in the source code #400

CelticMinstrel opened this issue Aug 10, 2024 · 2 comments

Comments

@CelticMinstrel
Copy link
Member

This issue merely serves as a reminder that TODO comments exist. It should not be closed, unless no TODO comments remain.

@NQNStudios
Copy link
Collaborator

NQNStudios commented Nov 10, 2024

// TODO: Why the heck are we drawing a whole line higher than requested!?

I'm going to hazard a guess about this TODO comment. Some APIs render the bottom-left corner of text at the position you request. Others render the top-left corner at that point. Maybe BoE used to use the first kind of API and switched to the second type when dependencies were modernized?

@CelticMinstrel
Copy link
Member Author

Oh, that's interesting. I have no idea if that's the case, but it's something that could probably be checked. BoE originally used the QuickDraw API for drawing text. Now we use SFML+Freetype.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants