-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to include additional files to bump #237
Comments
I understand your request. Could you provide some thoughts on how you would like it to work (configurations/settings, failure handling, etc)? |
Could the hooks functionality work? You can have a script that will add whatever files you want before the commit. |
It seems that could work, I have to try that sometime. Thanks for pointing it out. |
OK, I tried hook like: pre_commit_hooks = [
"git add CHANGELOG.rst",
] which works fine. The only problem is that I still have to use |
Then there must be other modified files. Add the hook 'git status' to see the state. Might need to run bump my version with -vvv |
Nope. It's an inherent feature of the process. The order of events is:
It's the same with I think it's OK to have check of dirty files before anything else to prevent unwanted changes to the code. But an option to list files which may be dirty would help. Something like: # These files are ignored in dirty check, event if --no-allow-dirty.
allow_dirty_files = ['CHANGELOG.rst', 'docs/changelog/*'] |
Thank you for the two PRs. I've given you write permission to the repository. Do you think you could create a branch with the changes? It would help us both out. |
Description
I'd like to suggest a new option to include additional files to
bump
commit. This would be especially useful to include changelog or similar release-related files.Currently, I use
--allow-dirty
. But that doesn't ensure thechangelog
is included to the git stage. This may cause the commit/tag to be created without necessary files.The text was updated successfully, but these errors were encountered: