Allow csrf to be updated on cookie refresh and add 401 error handling #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch :-) Will release ... next days |
|
I'm also waiting for the fix to fix the issues mentioned in bbindreiter/node-red-contrib-alexa-remote2-applestrudel#2 and cakebake/node-red-contrib-alexa-remote-cakebaked#31. @Apollon77 do you already know when this PR will be merged and a new version will be released? |
|
oohh yes there was something open ... ... ... will check |
|
Anything new about the merge of this PR? Isn't it just a click of a button? |
|
Release comes soon |
|
released as 4.1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if (!this.csrf && ar && ar.length >= 2) {
prevents the csrf being updated after a re-init with former registration data has returned a new csrf, this will result in 401 errors on certain commands (such as speech) if the csrf is out of date.
Also this doesnt appear to do anything:
if (!ar || ar.length < 2) ar = this.cookie.match(/csrf=([^;]+)/);
Also added handling of 401 errors (otherwise the failure is silent)
Should fix:
#57
fixes bbindreiter/node-red-contrib-alexa-remote2-applestrudel#2
fixes cakebake/node-red-contrib-alexa-remote-cakebaked#31