From 54dba907fdacd6954811c4051f791f741b7b7e40 Mon Sep 17 00:00:00 2001 From: "C. Augusto Proiete" Date: Sun, 16 Jul 2023 04:27:15 -0300 Subject: [PATCH] Apply suggestions from code review (/nr: => /nodeReuse:) --- .../Unit/Tools/DotNet/MSBuild/DotNetMSBuildBuilderTests.cs | 2 +- .../Tools/DotNet/MSBuild/MSBuildArgumentBuilderExtensions.cs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Cake.Common.Tests/Unit/Tools/DotNet/MSBuild/DotNetMSBuildBuilderTests.cs b/src/Cake.Common.Tests/Unit/Tools/DotNet/MSBuild/DotNetMSBuildBuilderTests.cs index ddbcd81a5a..541036be8f 100644 --- a/src/Cake.Common.Tests/Unit/Tools/DotNet/MSBuild/DotNetMSBuildBuilderTests.cs +++ b/src/Cake.Common.Tests/Unit/Tools/DotNet/MSBuild/DotNetMSBuildBuilderTests.cs @@ -814,7 +814,7 @@ public void Should_Use_Node_Reuse_If_Specified() var result = fixture.Run(); // Then - Assert.Equal("msbuild /nr:true", result.Args); + Assert.Equal("msbuild /nodeReuse:true", result.Args); } } diff --git a/src/Cake.Common/Tools/DotNet/MSBuild/MSBuildArgumentBuilderExtensions.cs b/src/Cake.Common/Tools/DotNet/MSBuild/MSBuildArgumentBuilderExtensions.cs index f5b85a11c7..46ea94d326 100644 --- a/src/Cake.Common/Tools/DotNet/MSBuild/MSBuildArgumentBuilderExtensions.cs +++ b/src/Cake.Common/Tools/DotNet/MSBuild/MSBuildArgumentBuilderExtensions.cs @@ -204,9 +204,9 @@ public static void AppendMSBuildSettings(this ProcessArgumentBuilder builder, Do } // Re-use of MSBuild nodes? - if (settings.NodeReuse != null) + if (settings.NodeReuse.HasValue) { - msBuilder.Append(string.Concat("/nr:", settings.NodeReuse.Value ? "true" : "false")); + msBuilder.Append(string.Concat("/nodeReuse:", settings.NodeReuse.Value ? "true" : "false")); } builder.AppendRange(