Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't use with hashbrown/nightly feature #209

Open
Imberflur opened this issue Jan 23, 2025 · 1 comment · May be fixed by #210
Open

Can't use with hashbrown/nightly feature #209

Imberflur opened this issue Jan 23, 2025 · 1 comment · May be fixed by #210

Comments

@Imberflur
Copy link

This crates uses allocator-api2 without exposing a feature to enable #![feature(allocator_api)].

Due to issues outlined here zakarumych/allocator-api2#19,
this makes it is impossible to have this crate anywhere in the dependency tree along with hashbrown when enabling the hashbrown/nightly feature.
@Imberflur Imberflur mentioned this issue Jan 23, 2025
Open
@cfallin
Copy link
Member

cfallin commented Jan 23, 2025

PR welcome -- I'm not really that familiar with the present allocator API situation. Adding a Cargo feature for this sounds reasonable to me.

It looks like our use of the crate came in with #196 -- @jakubDoka , any thoughts?

@jakubDoka jakubDoka linked a pull request Jan 24, 2025 that will close this issue
Open
github-actions bot pushed a commit to veloren/veloren that referenced this issue Jan 26, 2025
Crate updates
730e61e 
Tried to run `cargo update`, but that broke things, see
rust-lang/hashbrown#564.

Updated:
- itertools to 0.14
- kiddo to 5
- petgraph to 0.7
- notify to 8
- wasmtime and wasmtime-wasi to 29
  Note: this causes even bigger problems if one were to try to run
  `cargo update` since even if one were to add certain transitive
  dependencies to common/Cargo.toml and enable the necessary feature
  flags, a transitive dependency here also depends on allocator-api2 but
  without exposing the proper feature flag. A fix is underway, see
  bytecodealliance/regalloc2#209
- axum to 0.8
- discord-sdk to 0.4
- minifb to 0.28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adding feature to suport nightly features on dependencies jakubDoka/regalloc2
2 participants
@cfallin @Imberflur