Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fenced code blocks attributes in curly braces break highlighting #168

Open
sbaack opened this issue Mar 1, 2017 · 6 comments
Open

Fenced code blocks attributes in curly braces break highlighting #168

sbaack opened this issue Mar 1, 2017 · 6 comments
Assignees
Labels

Comments

@sbaack
Copy link

sbaack commented Mar 1, 2017

Thanks for this package. This issue is similar to #123. I usually add fenced code blocks attributes in curly braces, as in {.bib}. This breaks highlighting in language-markdown (gfm works fine):

screen shot 2017-03-01 at 11 33 42 am

Removing the curly braces fixes the issue:

screen shot 2017-03-01 at 11 33 52 am

I don't insist on using curly braces, it's just that I used to do it this way and I have a lot of older documents which I would have to readjust when I want to keep using language-markdown. Would be glad if this could be fixed.

@burodepeper
Copy link
Owner

It definitely seems related to #123. No idea why it's still an issue, will look into it. Could you verify for me if the problem persists if you switch bib to a language that is supported, like js?

@burodepeper burodepeper added the bug label Mar 1, 2017
@burodepeper burodepeper self-assigned this Mar 1, 2017
@sbaack
Copy link
Author

sbaack commented Mar 1, 2017

Thanks for the quick reply. This problem persists when I switch to {.js}.

@burodepeper
Copy link
Owner

And if you switch to {js} without the leading dot?

@sbaack
Copy link
Author

sbaack commented Mar 1, 2017

Doesn't work either. However, I found that if I remove the closing brace, highlighting works again regardless of the language used. So{.bib, {.js, {js all work, but {js} or {.js} don't.

@burodepeper
Copy link
Owner

That could very well be related to #139. {js } might work too. I'll soon have a look at it. I need some good tests to make sure it is truly fixed. Not sure why this keeps slipping through. Thanks for reporting.

@sbaack
Copy link
Author

sbaack commented Mar 1, 2017

You're right, {js } or {.bib } works. Thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants